Show recommendations of full changeset with opt-out #3892
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we show only the recommendations and suggestions for the mods the user selects. The recommendations and suggestions of dependencies aren't shown, even though the user stands to benefit from seeing them.
Changes
This is done with a new relationship resolver option,
get_recommenders
, which stops searching the relationship tree whensuppress_recommendations
is found.Fixes #3838.
As a courtesy, before the next release, we should submit pull requests adding
suppress_recommendations
to thedepends
relationships of these metanetkans:FYI to @NathanKell that this may be on its way.