Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two small typos in Resources.pt-BR.resx at line 182 #3943

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

idrkwhattoput
Copy link
Contributor

@idrkwhattoput idrkwhattoput commented Dec 12, 2023

Fixed small typos in line 182 (appears when the user tries to install a mod in a non-supported KSP version).

accidentaly discovered this when i was trying to install a mod, so here it is 👍

@HebaruSan
Copy link
Member

HebaruSan commented Dec 12, 2023

Hi @idrkwhattoput, thanks for the update! Was the other change intentional? The old text "mantenedores" seems to be a closer fit to the English "maintainers" than "colaboradores".

Also FYI that there's an easier way to edit these nowadays: https://crowdin.com/project/ckan

@HebaruSan HebaruSan added Bug GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating labels Dec 12, 2023
@idrkwhattoput
Copy link
Contributor Author

Hi @idrkwhattoput, thanks for the update! Was the other change intentional? The old text "mantenedores" seems to be a closer fit to the English "maintainers" than "colaboradores".

Also FYI that there's an easier way to edit these nowadays: https://crowdin.com/project/ckan

hello, yes the other change was intentional it maked more sense for me to put "colaboradores" instead of "mantenedores" im also looking out to help with the translation so thanks for the link

@HebaruSan
Copy link
Member

it maked more sense for me to put "colaboradores" instead of "mantenedores"

@idrkwhattoput, thanks, would you mind saying why you think that? As I mentioned earlier, "mantenedores" gives an exact match to the English translation when I put it into a translator.

@idrkwhattoput
Copy link
Contributor Author

idrkwhattoput commented Dec 12, 2023

it maked more sense for me to put "colaboradores" instead of "mantenedores"

@idrkwhattoput, thanks, would you mind saying why you think that? As I mentioned earlier, "mantenedores" gives an exact match to the English translation when I put it into a translator.

Hmmm, well then sorry, i never heard the word "mantenedores" when speaking Brazilian Portuguese 😅 so i thought it was incorrect.

@HebaruSan
Copy link
Member

Please don't close this. We need it to be open so we can merge your fixes into the main branch.

@HebaruSan HebaruSan reopened this Dec 12, 2023
@idrkwhattoput
Copy link
Contributor Author

idrkwhattoput commented Dec 12, 2023

oh sorry didnt know

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HebaruSan HebaruSan reopened this Dec 12, 2023
@HebaruSan HebaruSan merged commit 164d88a into KSP-CKAN:master Dec 12, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants