Fix uninstallation of manually deleted files and directories #3955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
During development to improve the "inconsistencies were found / is registered to but has not been removed" message in #3938, I thought the missing-file case only needed to sneak past
File.Delete
, which explicitly says it won't throw an exception:However, the underlying exception here is thrown elsewhere:
The
File.GetAttributes
call is and always has been the first thing that happens when deleting files, so that's why this section of code was so aggressive in ignoring exceptions prior to #3938.Changes
Now if
DirectoryNotFoundException
orFileNotFoundException
are thrown byFile.GetAttributes
, we log them as debug messages and ignore them. This allows uninstallation to finish for these mods. Exceptions thrown for other reasons, such as permissions or locked files, will still be collected into the error message from #3938.Fixes #3954.