Further improve netkan relationship error message #4021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4020 replaced the very unclear "Specified cast is not valid" message with a proper schema validation error. On further consideration, the schema error still isn't clear enough, because it doesn't explain why the array item is not valid.
Changes
Now the
RelationshipsValidator
explicitly checks the type of the elements of relationships arrays and prints a message that hopefully will be clearer: