Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show repo ETag and parsing errors in Failed Downloads #4030

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

HebaruSan
Copy link
Member

Problems

  • If you set up a custom repo of someone's ZIP on a server and then it is later removed, the 404 error will be reported in the message log instead of the Failed Downloads popup:
    image
  • If you set up a custom repo that points to a file that isn't a ZIP or .tar.gz, the error appears in the message log instead of the Failed Downloads popup:
    image

Causes

  • If a previously working repo is removed, Net.CurrentETag throws an exception when we try to get the latest ETag
  • If a downloaded repo file is in the wrong format, UnsupportedKraken is thrown when RepositoryDataManager.Update calls RepositoryData.FromDownload

The Failed Downloads popup depends on DownloadErrorsKraken, which isn't thrown in either case.

Changes

  • Now both classes of errors are redirected into DownloadErrorsKraken exceptions, so they show up in the Failed Downloads popup:
    image
    image
  • The Failed Downloads popup now has horizontal padding so the grid view doesn't abut the edge of the window
  • The string reporting the format problem wasn't internationalized and now has been

Fixes #4027.

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN i18n Issues regarding the internationalization of CKAN and PRs that need translating labels Feb 14, 2024
@HebaruSan HebaruSan merged commit cd15a0f into KSP-CKAN:master Feb 14, 2024
8 checks passed
@HebaruSan HebaruSan deleted the fix/repo-update-errors branch February 14, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Network Issues affecting internet connections of CKAN
Projects
None yet
1 participant