Build nuget package, support netstandard2.0 build #4039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@cheese3660 and @jan-bures have expressed an interest in using some functionality from CKAN in a future update of the KSP2 mod SpaceWarp. Currently this would require them to compile it themselves, which is not very convenient or maintainable.
This dovetails with a longstanding aspiration to make CKAN's core DLL available on Nuget for mods.
Changes
netstandard2.0
, because it is better for mods.nupkg
file containing DLLs fornet48
,net7.0
, andnetstandard2.0
.nupkg
file to be created (Windows already handles it in the single build-everything pass that we're already doing)NUGET_API_KEY
in this repo's secrets, it will be used to upload the generated.nupkg
file to Nuget when we make a releaseFixes #1031.
Fixes #1037.
Fixes #1588.
Important note
We have no established commitment to follow SemVer with respect to the core DLL's public types. The only current versioning rule is that we increment the minor version when we change the metadata spec/schema in ways that older clients can't support, and the patch version otherwise (which is always even for stable releases and odd for dev builds).
We might choose to make such a commitment in the future, but be aware that for now, if you use this DLL, any public stuff might change from one version to the next, so you should only update its dependency version if you are prepared to fix an unknown number of compile errors.