Launch wiki when Windows users select dev updates #4059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before #3997's dev builds functionality gets released, we need to do something about Windows' malware scanner's high false positive rate. It has always been a problem (in that it falsely flags ckan.exe as malware), but for full releases we (or interested users) can submit it for manual review and whitelisting. Dev builds are generated too frequently for that to be feasible.
Changes
https://github.com/KSP-CKAN/CKAN/wiki/Using-dev-builds-on-Windows
ckan upgrade ckan --dev-build
for the first time), we auto-open that page in a browser, so the user can read about the problem and decide how they want to handle it. This should at least take a big bite out of the problem of users' ckan.exe dev builds getting deleted by surprise. And for those who miss it the first time, we can send them the URL again when they come to complain on Discord.Fixes #4040 (since it addresses the malware scanner problem, and the specific suggestion given doesn't seem to be workable).