Pass image from smoke to deploy, restore build caching #4093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we build the Inflator image twice when pushing to
master
, once for smoke testing and again for pushing to Docker Hub. This is a small but not tiny amount of extra time and repeated work.Another few extra seconds are spent re-downloading build dependencies that formerly were cached in the old workflows.
Changes
build.cake
and intosmoke.yml
anddeploy.yml
using the standard docker actions and commands, in order to allow the steps to be separated and smoke testing inserted before push.https://github.com/docker/build-push-action
smoke.yml
now uploads a tar of the image as an artifact after the smoke test passeshttps://docs.docker.com/build/ci/github-actions/share-image-jobs/
https://docs.docker.com/build/ci/github-actions/test-before-push/
deploy.yml
now downloads the tar of the image and loads it instead of building itbuild.yml
This should eliminate some redundant work.