Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
-
prefix like all other searchesIt has worked this way since #3323 (and #3460 even partially explained why), but no one seemed to care.
Recently we finally got a report from Discord user Epsilon:
Cause
ModSearch
storesstring
s for tags butModuleLabel
s for labels. This was done because it's trivial to check whether a tag name matches a module by looking for it in theCkanModule.Tags
property, but the label object stores which mods it contains rather than the other way around. To check label membership, you need theModuleLabel
object, soModSearch
stored them, which meant that when we translate it back into a search string, partially typed label searches could not be represented since there was no such label in the list of labels.Changes
ModSearch.Labels
is replaced with a string listModSearch.LabelNames
which can contain partial names while the user is typingModSearch.MatchesLabels
is rewritten to handle looking up the labels fromModuleLabelList.ModuleLabels
and scan them for matching nameslabel:Favorites
matches all mods in the Favories label if it exists.-label:Favorites
excludes all mods in the Favories label if it exists.label:
by itself matches all mods with no labels.-label:
by itself excludes all mods with no labels.label:partial
matches nothing if there is no "partial" label.-label:partial
matches all mods if there is no "partial" label.