Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prepare-SignPath target to build script #4188

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Sep 21, 2024

Motivation

Release signing will go through an approval queue on the SignPath web site. One of us will have to create the release to generate the signing request, then approve the request on the web site to continue.

We plan to have three files signed (ckan.exe, AutoUpdater.exe, and CKAN.1.34.5.nupkg), which would require two separate requests and approvals as-is since the .nupkg file is in a different folder than the others. Ideally we could approve everything in one go.

The current workflows upload the _build/repack folder which contains several other files that don't need to be signed, like netkan.exe and the ILRepack log files.

Changes

Now if you run ./build Prepare-SignPath --configuration=Release (case insensitive, I believe), a _build/signpath/Release directory will be created containing:

  • ckan.exe
  • AutoUpdater.exe
  • CKAN.1.34.5.nupkg (version string auto-generated based on the changelog)

This path can then be passed to the signpath/github-action-submit-signing-request action to request signing for all three of those files at once, once we create a configuration for that on the SignPath web site.

Note that ./build Prepare-SignPath --configuration=Release --exclusive can be used to skip the compilation and repack steps and only copy files into the dir if the requisite build steps have already been completed.

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix Build Issues affecting the build system Cake Issues affecting Cake labels Sep 21, 2024
@HebaruSan HebaruSan merged commit 982bc5c into KSP-CKAN:master Sep 21, 2024
3 checks passed
@HebaruSan HebaruSan deleted the feature/build-prepare-signpath branch September 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issues affecting the build system Cake Issues affecting Cake Easy This is easy to fix Enhancement New features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant