Add Prepare-SignPath target to build script #4188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release signing will go through an approval queue on the SignPath web site. One of us will have to create the release to generate the signing request, then approve the request on the web site to continue.
We plan to have three files signed (
ckan.exe
,AutoUpdater.exe
, andCKAN.1.34.5.nupkg
), which would require two separate requests and approvals as-is since the.nupkg
file is in a different folder than the others. Ideally we could approve everything in one go.The current workflows upload the
_build/repack
folder which contains several other files that don't need to be signed, likenetkan.exe
and theILRepack
log files.Changes
Now if you run
./build Prepare-SignPath --configuration=Release
(case insensitive, I believe), a_build/signpath/Release
directory will be created containing:ckan.exe
AutoUpdater.exe
CKAN.1.34.5.nupkg
(version string auto-generated based on the changelog)This path can then be passed to the
signpath/github-action-submit-signing-request
action to request signing for all three of those files at once, once we create a configuration for that on the SignPath web site.Note that
./build Prepare-SignPath --configuration=Release --exclusive
can be used to skip the compilation and repack steps and only copy files into the dir if the requisite build steps have already been completed.