Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Secret Inheritence #4190

Merged
merged 1 commit into from
Sep 22, 2024
Merged

ci: Secret Inheritence #4190

merged 1 commit into from
Sep 22, 2024

Conversation

techman83
Copy link
Member

Shared workflows do not automatically get access to the secrets from the parent workflow. Either secrets must be passed through individually or you can choose to inherit them

Shared workflows do not automatically get access to the secrets from
the parent workflow. Either secrets must be passed through individually
or you can choose to inherit them
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I would have thought these secrets came from the repo, not from a particular workflow. Weird architectural choice, I guess. Thanks for solving it!

@HebaruSan HebaruSan added the Build Issues affecting the build system label Sep 22, 2024
@HebaruSan HebaruSan merged commit 146b30f into KSP-CKAN:master Sep 22, 2024
3 checks passed
@techman83 techman83 deleted the fix/signing branch September 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issues affecting the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants