Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compat of new instances based on Unity updates and alert user #4191

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Sep 22, 2024

Motivation

One of the top user support requests at the moment is still how to make more mods show up as installable, with the answer still being to set compatible versions in the settings to work around still-missing compatibility metadata updates from mod authors:

image

Cause

New users have no concept of the history of game updates and mod updates and how they interacted; they see a more or less static landscape, and it doesn't make sense to them that they would have to change settings to install anything.

Meanwhile, a great number of mods that still work in the latest version were abandoned long before it was released, and so their compatibility still only goes up to whatever was the latest game version at that time.

Changes

  • Now IGame.DefaultCompatibleVersions(GameVersion) defines which additional versions should be considered compatible for a given installed game version by default (user can still edit)
    • For KSP1, this is implemented as returning the major+minor versions between the most recent significantly compatibility-breaking Unity upgrade and the installed verson, inclusive. For KSP 1.12.5, the default is 1.8–1.12.
    • For KSP2, this is implemented as covering all released game versions (0.1 and 0.2), because version compatibility never really became a thing for that game
    • A few new tests exercise the above behaviors
    • When a game instance is loaded, if it has no compatible versions set:
      • The above default range is copied into the settings
      • The compatible game versions popup appears with a message about the defaulting that just happened, so users can know about it and take action if they don't like it
        image
  • The extra OK-only popup that announced an updated game version is now replaced by a top-message as for the above feature (even if no one ever sees it again)

This should help new users to find the mods they're looking for with a lower support burden, and expert users who prefer other settings can select them in the pop-up.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN labels Sep 22, 2024
@HebaruSan HebaruSan changed the title Set compat of new instances based on Unity updates and and alert user Set compat of new instances based on Unity updates and alert user Sep 22, 2024
@HebaruSan HebaruSan merged commit 5986e89 into KSP-CKAN:master Sep 22, 2024
3 checks passed
@HebaruSan HebaruSan deleted the feature/auto-compat-verbose branch September 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant