Allow installs and removals to be cancelled #4253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The GUI progress screen has a Cancel button, but it only works while a download is in progress. If you try to cancel after the downloads are finished but installation is still in progress, the button disables itself and nothing else happens.
Cause
The downloaders have their own custom
CancelDownload
methods, but theModuleInstaller
has nothing equivalent.Changes
CancellationToken
s in their constructors and throwCancelledActionKraken
in place of their proprietary APIs. TheCancelledActionKraken
causes the installation transaction to abort, which restores the original state of the game folder.ModuleInstaller
is updated to work the same way and checks the token in between installing or removing filesCancellationToken
This allows the Cancel button to work regardless of which step is currently in progress.