Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of work on GUI #83

Merged
merged 35 commits into from
Oct 18, 2014
Merged

A lot of work on GUI #83

merged 35 commits into from
Oct 18, 2014

Conversation

AlexanderDzhoganov
Copy link
Member

I have fixed some stuff and added some more new stuff. All in all the GUI code is quickly closing the feature gap with command line.

EndGlobalSection
GlobalSection(MonoDevelopProperties) = preSolution
StartupItem = CKAN\CKAN.csproj
Policies = $0
$0.TextStylePolicy = $1
$0.TextStylePolicy = $5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what Visual Studio did here, better not merge the .sln file

@pjf
Copy link
Member

pjf commented Oct 17, 2014

You are amazing. I've just got back from watching the USS Pinafore, and I'm about to crash into bed, but I'm really looking forward to getting up in the morning and looking over your code! :) Thank you so much! <3

this doesn't work currently because JSON.NET doesn't support version v4
and throws on our schema
also added comments to several functions
installer.Uninstall(module, false);
}

// Prepare options. Can these all be done in the new() somehow?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they really should be. Or a var install_ops = GetResolverOptions(options) which does it for us.

@pjf
Copy link
Member

pjf commented Oct 18, 2014

This is looking good to me, but I want to just tweak a couple of minor things while they're in my head before I merge. (Defaults for relationship resolution, .gitignore files, tutorial installation, etc.)

@pjf
Copy link
Member

pjf commented Oct 18, 2014

Merging away!

pjf added a commit that referenced this pull request Oct 18, 2014
@pjf pjf merged commit cfe317a into KSP-CKAN:master Oct 18, 2014
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
I have *no idea* why we've got a github token compiled into our code.

* Reverts commit d82f3c4.
* Reverts PR KSP-CKAN#83.
* Closes KSP-CKAN/CKAN-support#113.
RichardLake added a commit to RichardLake/CKAN that referenced this pull request May 30, 2015
Add new all filter which displays all the mods.
With KSP-CKAN#83 closes KSP-CKAN/CKAN-support#121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants