-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A lot of work on GUI #83
Conversation
- Integrated User.WriteLine and User.YesNo with the GUI - Added configuration serialization - Added ErrorDialog - Added YesNoDialog - Added status bar log - Added repository to settings window
EndGlobalSection | ||
GlobalSection(MonoDevelopProperties) = preSolution | ||
StartupItem = CKAN\CKAN.csproj | ||
Policies = $0 | ||
$0.TextStylePolicy = $1 | ||
$0.TextStylePolicy = $5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what Visual Studio did here, better not merge the .sln file
You are amazing. I've just got back from watching the USS Pinafore, and I'm about to crash into bed, but I'm really looking forward to getting up in the morning and looking over your code! :) Thank you so much! <3 |
this doesn't work currently because JSON.NET doesn't support version v4 and throws on our schema also added comments to several functions
… added overwrite option for files
installer.Uninstall(module, false); | ||
} | ||
|
||
// Prepare options. Can these all be done in the new() somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they really should be. Or a var install_ops = GetResolverOptions(options)
which does it for us.
This is looking good to me, but I want to just tweak a couple of minor things while they're in my head before I merge. (Defaults for relationship resolution, .gitignore files, tutorial installation, etc.) |
Merging away! |
Add github token for update requests
I have *no idea* why we've got a github token compiled into our code. * Reverts commit d82f3c4. * Reverts PR KSP-CKAN#83. * Closes KSP-CKAN/CKAN-support#113.
Add new all filter which displays all the mods. With KSP-CKAN#83 closes KSP-CKAN/CKAN-support#121
I have fixed some stuff and added some more new stuff. All in all the GUI code is quickly closing the feature gap with command line.