Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShadowUtilityLIB depends to CheatsMenu #33

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Add ShadowUtilityLIB depends to CheatsMenu #33

merged 1 commit into from
Apr 16, 2023

Conversation

NathanPeake
Copy link
Contributor

Added missing dependency ShadowUtilityLIB

@NathanPeake
Fix CheatsMenu.netkan
3b32008 
Added missing dependency
@NathanPeake
Copy link
Contributor Author

Requires #20

@HebaruSan

This comment was marked as resolved.

Sign in to view
@HebaruSan

This comment was marked as resolved.

Sign in to view
@HebaruSan HebaruSan changed the title Fix CheatsMenu.netkan Add ShadowUtilityLIB depends to CheatsMenu Apr 15, 2023
@HebaruSan
Copy link
Member

You should also mention it in the README on GitHub and/or in the download.

https://github.com/Bit-Studios/CheatMenu

image

image

@NathanPeake
Copy link
Contributor Author

Hi @NathanPeake, thanks for letting us know about this. For what it's worth, we set the dependencies of CKAN by looking in the same places users would...

You should mention this on SpaceDock so users know they need to install it.

https://spacedock.info/mod/3266/Cheats%20Menu

image

Thanks @HebaruSan for reminding me to update them areas.

HebaruSan
HebaruSan approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@HebaruSan HebaruSan merged commit 8f650e3 into KSP-CKAN:main Apr 16, 2023
@NathanPeake NathanPeake deleted the CheatsMenu-Depend-fix-1 branch April 17, 2023 08:15
@NathanPeake NathanPeake restored the CheatsMenu-Depend-fix-1 branch April 17, 2023 08:15
@NathanPeake NathanPeake deleted the CheatsMenu-Depend-fix-1 branch April 17, 2023 08:15
@HebaruSan HebaruSan mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HebaruSan HebaruSan HebaruSan approved these changes

Assignees
No one assigned
Labels
Fix relationships
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanPeake @HebaruSan