Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The set-output command is deprecated and will be disabled in June 2023 #16

Closed
zer0Kerbal opened this issue Nov 5, 2022 · 6 comments
Closed
Labels
invalid This doesn't seem right question Further information is requested

Comments

@zer0Kerbal
Copy link
Contributor

zer0Kerbal commented Nov 5, 2022

The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@HebaruSan HebaruSan changed the title [Bug] The save-state command is deprecated and will be disabled soon The set-output command is deprecated and will be disabled in June 2023 Nov 6, 2022
@HebaruSan
Copy link
Member

Looking into this, it doesn't seem like this is submitted in the right place. The only occurrence of save-state or set-output anywhere in this repo is in our own workflows, which will need to be updated before the deadline, but which would not affect any other projects.

Can I ask why you thought this project was responsible for this warning?

@HebaruSan HebaruSan added the question Further information is requested label Nov 6, 2022
@HebaruSan
Copy link
Member

HebaruSan commented Nov 6, 2022

For reference, these are the places in the KSP-CKAN org where we use set-output (we don't use save-state anywhere):

run: |
echo -n '::set-output name=upload_url::'
curl -fsSL https://api.github.com/repos/$GITHUB_REPOSITORY/releases/latest | jq -rM '.upload_url'
echo -n '::set-output name=nupkg_basename::'
basename _build/KSPMMCfgParser/Release/bin/KSPMMCfgParser.*.nupkg

https://github.com/KSP-CKAN/CKAN/blob/3dfcf3edf86bd316eaf9c6aa807bf643ad770548/.github/workflows/release.yml#L58-L66

https://github.com/KSP-CKAN/CKAN/blob/3dfcf3edf86bd316eaf9c6aa807bf643ad770548/.github/workflows/deploy.yml#L27-L32

@HebaruSan
Copy link
Member

OK, as of KSP-CKAN/CKAN#3696 and #17, I think all uses of set-output in the KSP-CKAN org are eliminated.
But note that this won't fix whatever problem you were having, because this wasn't the cause of it, as noted.

@zer0Kerbal
Copy link
Contributor Author

this has been showing up when using the action:

Just wanted you to know - in case it was going to break the action.

Happy belated 🎃

image

@HebaruSan
Copy link
Member

Yeah, that's not from anything we're doing. Some other part of the workflow is triggering that.

@zer0Kerbal
Copy link
Contributor Author

okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants