Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch workflows from set-output to $GITHUB_OUTPUT #3696

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

HebaruSan
Copy link
Member

Motivation

Originally, the documented way to pass info from one GitHub workflow step to the next was to print this to stdout:

::set-output name=param_name::param_value

We used this in several places in CKAN's workflows (mainly dealing with the calculation of the version strings).

Recently GitHub decided they didn't like that anymore and added a warning message for it:

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The replacement is to append param_name=param_value lines to the file specified by $GITHUB_OUTPUT:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

We have until June 2023 to migrate.

Noted thanks to KSP-CKAN/KSPMMCfgParser#16.

Changes

Now the prescribed migration is done for the CKAN repo.

I'll self-review this.

@HebaruSan HebaruSan added Easy This is easy to fix Pull request Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels Nov 6, 2022
@HebaruSan HebaruSan merged commit 57d65dc into KSP-CKAN:master Nov 6, 2022
@HebaruSan HebaruSan deleted the fix/workflows-set-output branch November 6, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant