Handle bad author list input from SpaceDock #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
|
Worked! KSP-CKAN/KSP2-NetKAN#17
|
This was referenced Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #293, the SpaceDockAdder is repeatedly failing for a mod with co-authors.
Cause
After #293, we can see that SpaceDock is passing a string where it's supposed to pass a list of dicts:
(
usernameis the first key in the contained dicts)Changes
Now the SpaceDockAdder performs run-time type checks on the shared authors property and only uses it to generate the PR body if it's correct. Otherwise an error is logged.
This will allow the bot to finally finish processing the request that's been stuck in the queue. The underlying SpaceDock bug will be fixed later.