Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave spec version out of generated netkans #336

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Leave spec version out of generated netkans #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88604d5
Leave spec version out of generated netkans
HebaruSan Aug 11, 2024
0d5518c
Disable coverage again
HebaruSan Aug 11, 2024
737d410
Try false inside the double curly braces
HebaruSan Aug 11, 2024
c3e95fd
Just disable the step that's throwing an NRE
HebaruSan Aug 11, 2024
e0a3528
I guess it's only looking at the master branch, go back to disabling …
HebaruSan Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions:
jobs:
coverage-report:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
if: ${{ false && github.event.workflow_run.conclusion == 'success' }}
steps:
- uses: actions/download-artifact@v4
with:
Expand Down
1 change: 0 additions & 1 deletion netkan/netkan/cli/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ def analyze_mod(common: SharedArgs, ident: str, download_url: str) -> None:
yaml.dump(ModAnalyzer(ident, download_url, common.game(common.game_id or 'KSP'))
.get_netkan_properties(),
sio)
click.echo('spec_version: v1.18')
click.echo(f'identifier: {ident}')
click.echo(sio.getvalue())

Expand Down
2 changes: 0 additions & 2 deletions netkan/netkan/spacedock_adder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ def make_spacedock_netkan(self, ident: str, info: Dict[str, Any]) -> Dict[str, A
self.__class__.__name__, ident, url, exc_info=exc)
vref_props = {'$vref': props.pop('$vref')} if '$vref' in props else {}
return {
'spec_version': 'v1.34',
'identifier': ident,
'$kref': f"#/ckan/spacedock/{info.get('id', '')}",
**(vref_props),
Expand Down Expand Up @@ -191,7 +190,6 @@ def make_github_netkan(self, ident: str, gh_repo: Repository, info: Dict[str, An
self.__class__.__name__, ident, url, exc_info=exc)
vref_props = {'$vref': props.pop('$vref')} if '$vref' in props else {}
netkan = {
'spec_version': 'v1.34',
'identifier': ident,
'$kref': f"#/ckan/github/{gh_repo.full_name}",
**(vref_props),
Expand Down
Loading