Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KSRSS #10165

Closed
wants to merge 9 commits into from
Closed

Add KSRSS #10165

wants to merge 9 commits into from

Conversation

DeltaDizzy
Copy link
Contributor

@DeltaDizzy DeltaDizzy commented Aug 14, 2024

@DeltaDizzy
Copy link
Contributor Author

It seems that x_netkan_gitlab.use_source_archive: true doesn't actually work or I don't understand how it is supposed to be used?

@HebaruSan
Copy link
Member

HebaruSan commented Aug 14, 2024

It seems that x_netkan_gitlab.use_source_archive: true doesn't actually work or I don't understand how it is supposed to be used?

Yeah, x_netkan_gitlab is an object. I pushed a commit showing the correct usage.

Please don't merge this yet. It's not ready; the latest changes are on a separate branch at https://gitlab.com/ksrss/KSRSS/-/tree/reborn which hasn't had a release made yet. When that happens, the install and relationships will probably change, perhaps drastically.

We'll also need clarification on the textures. The May 2020 release says it depends on https://github.com/KerbalFrench/KSRSS-Textures, but it also contains its own Textures folder, so we'd need to confirm whether that's a real dependency and also whether it's current for this new reborn branch. If so, we'll need to make 3 additional modules for the 4k, 8k, and 16k textures and make them mutually exclusive provides-based dependencies of the main module.

@JonnyOThan
Copy link
Contributor

The reborn version does not depend on external textures.

@HebaruSan
Copy link
Member

Let's re-open this if a usable release actually happens.

@HebaruSan HebaruSan closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mod] KSRSS
3 participants