Add TweakScale-Redist, filter DLL from IR and FAR #9114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #9108, while the
Scale_Redist.dllwas initially supposed to be redistributed by all mods that need it (to integrate with TweakScale), this has changed recently, likely as a response to KSP 1.12.0-2's crash on duplicate DLLs bug.Solution
Now we split the
999_Scale_Redist.dllinto a separate moduleTweakScale-Redist.TweakScale itself, InfernalRoboticsRealismOverhaul, InfernalRoboticsNext and FerramAerospaceResearchContinued have been updated to filter the
Scale_Redist.dlland depend on TweakScale-Redist.I couldn't find any other bundlers looking through
dep:TweakScale,rec:TweakScale,sug:TweakScale. We have to wait for user reports to find all of them.According to the README the redist is licensed WTFPL.
Fixes #9108