Split out play modes for ClassicStockResources #9904
Conversation
NetKAN/ClassicStockResources.netkan
Outdated
| - name: CommunityResourcePack | ||
| depends: | ||
| - name: ModuleManager | ||
| - name: WildBlue-PlayMode-ClassicStock |
There was a problem hiding this comment.
we want to remove this one right?
There was a problem hiding this comment.
I'm pretty sure Simplified play mode requires it
There was a problem hiding this comment.
Confirmed that the Simplified play mode disables ClassicStockResources, see #9899 (comment).
There was a problem hiding this comment.
I still think this is wrong, there are a number of mods that use ClassicStockResources but don't need a WBI play mode.
https://github.com/search?q=repo%3AKSP-CKAN%2FNetKAN%20ClassicStockResources&type=code
There was a problem hiding this comment.
ClassicStockResources is part of the ClassicStock play mode. If a mod "uses" (note, that's not the same as supports or suggests, which is most of what is linked there) it, then it uses the ClassicStock play mode.
It may also be worth questioning how accurate those metadata entries are. "Classic Stock Resources" is a very generic sounding identifier, so it's not inconceivable that a mod author may list it in a relationship thinking that they're saying they support the stock resource system, not realizing that it's actually a specific part of a specific family of mods with its own requirements and quirks.
There was a problem hiding this comment.
ClassicStockResources is part of the ClassicStock play mode
I don't think this is true. Other playmodes may disable ClassicStockResources, but that's not the same thing.
There was a problem hiding this comment.
Right. All but one .cfg file is part of that play mode. The remaining one is generically available. That's modeled in the latest changes. I'd recommend taking a look at the files, then opening CKAN, clicking Refresh, and taking it for a spin to see how it all works.
|
This is due to taniwha.org being broken (see #9734), which we can't fix because Kethane has no alternate downloads. Not much choice but to ignore this error. |
|
And now we're getting an error due to Angel-125/DSEV#20. Again we'll probably just have to ignore it, since attempts to reach out on GitHub, Discord, and the forum have failed. |
HebaruSan
changed the title
| - name: Buffalo-PlayMode | ||
| - name: ModuleManager | ||
| - name: WildBlueTools | ||
| - name: ClassicStockResources |
There was a problem hiding this comment.
Wait I don't think this is correct either, doesn't this prevent you from using any playmode other than classic stock?
There was a problem hiding this comment.
No, the changes evolved a bit as I worked through this, hence the title change. The description should be up to date.
Motivations
These mods bundle ClassicStockResources:
If you install any of them manually and choose the ClassicStock play mode, the ClassicStockResources configs will be active. However, if you install with CKAN and pick the ClassicStock play mode, ClassicStockResources is not installed (unless the user chooses it). This isn't the expected/intended state of the mod in that case.
In addition, most but not all of ClassicStockResources's .cfg files are renamed to .txt if you pick any play mode other than ClassicStock. But in CKAN you can end up with all or none of the .cfg files when you should only have one.
Finally, PathFinder installs
GameData/WBIPlayMode.cfg, which is bad because it means this file will be overwritten at install and upgrade.Changes
GameData/WBIPlayMode.cfgis no longer installed by PathfinderFixes #9899 (once the historical PR in CKAN-meta is done).
Fixes #9905.