Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make createorbit() take mean anomaly at epoch in degrees #2689

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

vyznev
Copy link
Contributor

@vyznev vyznev commented Apr 5, 2020

This fixes issue #2681. I ran into this issue myself while testing a fix for #2687, so I fixed it and then found this earlier report.

In particular, with this patch, the following function now successfully clones an orbit:

function cloneorbit {
	parameter o is orbit.
	return createorbit(
		o:inclination,
		o:eccentricity,
		o:semimajoraxis,
		o:lan,
		o:argumentofperiapsis,
		o:meananomalyatepoch,
		o:epoch,
		o:body
	).
}

@Dunbaratu Dunbaratu added Breaking Some user scripts that used to work will break (even if just in a minor way). enhancement Something new (not a bug fix) is being requested labels Aug 10, 2020
@Dunbaratu
Copy link
Member

"Breaking" label added because previously written scripts would have called it with radians.

@Dunbaratu Dunbaratu merged commit 2b6640e into KSP-KOS:develop Aug 10, 2020
@vyznev vyznev deleted the createorbit_degtorad_fix branch August 31, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Some user scripts that used to work will break (even if just in a minor way). enhancement Something new (not a bug fix) is being requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants