Implement major/minor program support. #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NathanKell
commented
Jun 27, 2023
NathanKell
commented
- Programs now have a 'slots' field. *Admin Building now has a slot limit rather than program limit
- Apply slots field to all existing programs
- Add upgrade script to handle transition from pre-2.4 Admin.
|
Download the artifacts for this pull request: |
NathanKell
force-pushed
the
MinorPrograms
branch
2 times, most recently
from
129e190
to
83037f9
Compare
* Programs now have a 'slots' field. *Admin Building now has a slot limit rather than program limit * Apply slots field to all existing programs * Add upgrade script to handle transition from pre-2.4 Admin.
|
Love it! Thanks for implementing it in an even better format than I was thinking. One suggestion - space stations should probably also be 4 slots, based purely on the funding provided (15 million over 10 years with no curve, compared to 18 million over 9 years with a backloaded curve for crewed lunar). |
|
Hmm, think it depends on what form that program takes. but fair point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.