Log individual maintenance components & many more #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
siimav
force-pushed
the
AllYourDataIsBelongToUs
branch
from
c4a0dd4
to
79f1f5e
Compare
siimav
force-pushed
the
AllYourDataIsBelongToUs
branch
from
79f1f5e
to
d1fa249
Compare
|
LGTM except the log line about totalupkeep is busted now (you need to divide by timeFactor, since you multiplied it into totalUpkeep) but I think we can just kill that log line and its associated error checking since there hasn't been any reported errors around maintenance and subsidy since I, err, Finally Fixed It (tm). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat tested this.