Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on-pad vessel repairs #2327

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Add on-pad vessel repairs #2327

merged 1 commit into from
Feb 4, 2024

Conversation

siimav
Copy link
Contributor

@siimav siimav commented Jan 27, 2024

Creates a new option into the vessel recovery dialog that allows queueing up a repair of all failures. Only available for VAB-built vessels while in prelaunch state. This operation is blocking (i.e cannot build another vessel at the same time in that LC) and currently takes 1/7.5 of rollout time. No additional cost other than what is paid for engineer salary.

Things included in a repair:

  • Reset all kinds of failures (except Explosion! for [hopefully] obvious reasons)
  • Reset engine runtimes to 0
  • Restore ignition counts to initial values

Things NOT included in a repair:

  • Increase TF per-flight du cap
  • Increase TF initial data so that the engine would become more reliable on attempt 2

TODO

  • 16x16 png wrench icon

Depends on KSP-RO/TestFlight#284
Soft-depends on KSP-RO/RealFuels#336

Copy link

github-actions bot commented Feb 4, 2024

Download the artifacts for this pull request:

@siimav siimav merged commit adebe39 into master Feb 4, 2024
3 checks passed
@siimav siimav deleted the 🔧 branch February 4, 2024 13:39
@jwvanderbeck
Copy link
Contributor

So now you get 0 data for pre-launch failures? That seems a bit harsh to me. Should get t least some, even if it is less than the default, no?

@siimav
Copy link
Contributor Author

siimav commented Mar 8, 2024

No, you get 1000 but it isn't possible to earn anything on top of that after repairing the failures and actually launching. There's a 1000 du per-flight cap that still applies here.

@jwvanderbeck
Copy link
Contributor

oh ok this:

Things NOT included in a repair:
Increase TF initial data so that the engine would become more reliable on attempt 2

Confused me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants