Module Engines Solver Optimizations #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set engine temp string via guiUnits in Start instead of building every FixedUpdate (Unnecessary GC pressure) Add profiling calls Use nameof instead of hard-coded strings Remove redundant KSPField (default) declarations Tweak NK's caching of the unit strings!
Don't test exhaust damage for each engine & transform when operating. Instead, queue the engine to a deferred calculator that runs after all PartModules and does a single batched raycast.
Breaking change necessitates new version: removal and addition of KSPFields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented deferred exhaust damage calculator for one batched raycast, instead of many single casts.
Cleaned up memory allocations and unneeded string settings.
Left some Profiler calls to highlight other areas that may need improvement.