Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old links from navbar dropdown #259

Merged
merged 2 commits into from
May 28, 2020

Conversation

DasSkelett
Copy link
Member

Motivation

There are old links in the navbar dropdown that are no longer valid:

  • A link to a SpaceDock Mumble server, doesn't exist anymore AFAIK
  • The "Blog" theoretically exists, but it is not in use.
  • The "Chat" should theoretically link to IRC, but somehow doesn't work and links to the current page instead. Since we also link to the IRC chat in the footer, it's not needed up there.

Changes

These are all removed from the dropdown menu.

Additionally I removed the systemd remnants of spacedock-notify which is no longer in use. This was originally part of #258.

@DasSkelett DasSkelett added Type: Improvement Priority: Low Status: Ready Area: Frontend Related to HTML, JS, CSS, or other browser things labels May 14, 2020
@DasSkelett
Copy link
Member Author

Restored the blog entry (and rebased on alpha)

Copy link
Contributor

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@HebaruSan HebaruSan merged commit d34ba79 into KSP-SpaceDock:alpha May 28, 2020
@DasSkelett DasSkelett deleted the remove-old-links branch May 28, 2020 21:11
HebaruSan pushed a commit that referenced this pull request Jun 3, 2020
* Remove old links from navbar dropdown menu

* Remove spacedock-notify systemd remnants
@HebaruSan HebaruSan mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Status: Ready Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants