Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod stats chart fixes #332

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Mod stats chart fixes #332

merged 1 commit into from
Nov 12, 2020

Conversation

HebaruSan
Copy link
Contributor

@HebaruSan HebaruSan commented Oct 15, 2020

Problems

Changes

  • Full month names are replaced with 3-letter abbreviations (e.g., "Jan")
  • The old static copy of chart.js is removed, and to replace it, we install the latest version of it with npm
  • The old version legend is removed and replaced by the chart's built-in legend, with a small font and small boxes to fit lots of versions
  • The new version of chart.js doesn't overlap the bars or X axis labels
  • The new version of chart.js handles very long X axis labels better, so the chart is still visible
  • The new version of chart.js also allows us to render the bars in different colros, so we match them to the top graph's versions

This screenshot shows a mod with 4 versions, temporarily and artificially dupicated for testing:

image

Note that this PR includes and is branched off of #310, in order to benefit from that PR's implementation of browserify to install dependencies via npm. The idea is that we would merge that PR and then look at this one. Focus on the second commit for the changes described here.

@HebaruSan HebaruSan added Priority: Normal Status: Ready Area: Frontend Related to HTML, JS, CSS, or other browser things labels Oct 15, 2020
@HebaruSan HebaruSan force-pushed the fix/chart branch 2 times, most recently from add0529 to ea7535c Compare October 27, 2020 00:40
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks fine now. I like it!

@HebaruSan HebaruSan merged commit 05ccf8d into KSP-SpaceDock:alpha Nov 12, 2020
@HebaruSan HebaruSan deleted the fix/chart branch November 12, 2020 19:41
@HebaruSan HebaruSan mentioned this pull request Mar 14, 2021
@HebaruSan HebaruSan mentioned this pull request May 22, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Normal Status: Ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants