Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messaging for descriptionless modpacks #351

Merged
merged 1 commit into from
May 13, 2021

Conversation

HebaruSan
Copy link
Contributor

Problem

If a user creates a modpack without a description, SpaceDock displays this message:

screenshot

It's wrong in two ways:

  1. The user is addressed as if they own the mod pack even if they aren't the creator and could not edit it
  2. It suggests that there are no mods added, even if there are several added

Cause

Just sloppiness in the mod_list.html template.

Changes

  • Now if you can't edit, the message just says "No description."
  • Now if you can edit and there are mods, the message just mentions the description being missing
  • Otherwise the current message is shown

@HebaruSan HebaruSan added Type: Bug Priority: Low Area: Frontend Related to HTML, JS, CSS, or other browser things labels May 11, 2021
@HebaruSan HebaruSan requested a review from DasSkelett May 11, 2021 19:49
@DasSkelett DasSkelett merged commit 732e402 into KSP-SpaceDock:alpha May 13, 2021
@HebaruSan HebaruSan deleted the fix/modpack-empty-msg branch May 13, 2021 18:25
This was referenced May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants