Allow http or nothing in forum links #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Type: Bug
Area: Backend
HebaruSan
force-pushed
the
fix/old-forum-links
branch
from
aaeec3c
to
7b5d40e
Compare
This comment has been minimized.
This comment has been minimized.
DasSkelett
reviewed
Jun 28, 2021
HebaruSan
force-pushed
the
fix/old-forum-links
branch
2 times, most recently
from
65ca4b0
to
e612e37
Compare
|
OK, I tested the "http://", "https://", and "nothing" case, and all three gave me working links to the forum. If there was a problem with the "nothing" case previously, it wasn't what I thought now. |
HebaruSan
force-pushed
the
fix/old-forum-links
branch
2 times, most recently
from
6244350
to
d41b0c5
Compare
DasSkelett
reviewed
Jul 2, 2021
HebaruSan
force-pushed
the
fix/old-forum-links
branch
from
d41b0c5
to
96df03a
Compare
DasSkelett
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #331, we added automatic parsing of forum links on the profile page to make them more easily clickable.
However, thanks to #345, we are able to easily jump back to the very earliest accounts, which predate the ubiquity of HTTPS on the interwebs, so their forum links start with
http://:One user even left off that part of the URL completely:
Currently these profiles do not benefit from the parsing and formatting of #331.
Cause
The regex for parsing the links starts with
https. This is unnecessarily restrictive.Changes
Now the regex allows
http://links or justforum....