Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parachutes in symmetry keep their spread angle after decoupling #107

Closed
gotmachine opened this issue Dec 30, 2022 · 0 comments
Closed

Parachutes in symmetry keep their spread angle after decoupling #107

gotmachine opened this issue Dec 30, 2022 · 0 comments
Labels
kspBug Identified KSP issue

Comments

@gotmachine
Copy link
Contributor

gotmachine commented Dec 30, 2022

See initial report on the forums

The ModuleParachute.symmetryCount field is keeping track of the symmetry group part count by updating it in a onVesselWasModified callback. Unfortunately, symmetry counterparts aren't updated yet when the event is called. Consequently, a chute that was in a symmetry group and then becomes "alone" following decoupling will retain the original symmetry count, resulting in the spread angle being applied and the chute drag being reduced.

Note that this is arguably a deeper KSP bug, as you would expect symmetry counterparts to be correctly updated on new Vessel instantiation following a decoupling, but fixing that globally is too likely to have side effects with foreign code relying on this stock behavior in a way or another. But for reference, the issue is in Part.decouple() calling CleanSymmetryVesselReferencesRecursively() after the decoupled Vessel has been initialized.

In our case, the issue can somewhat be worked around by using the onPartDeCoupleNewVesselComplete event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kspBug Identified KSP issue
Development

No branches or pull requests

1 participant