Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robotics extension/position field reset to default after scene switch #72

Closed
gotmachine opened this issue Aug 5, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@gotmachine
Copy link
Contributor

From forum user Thatguywholikesionengines :

I'm using a docking port attached to a robotic piece on an SSTO for space reasons. I leave it extended while i go do other things with other craft for clearance issues. I come back, undock, and try to retract the robotic bit - But it's reset to zero extension. Extending the robotic piece just makes it stick out unnaturally far.

Something similar was reported on Discord. Unsure what could be causing this, needs investigation.

@gotmachine gotmachine added the bug Something isn't working label Aug 5, 2022
@Jan-Arbus
Copy link

This bug also resets the action group.

@gotmachine
Copy link
Contributor Author

gotmachine commented Nov 15, 2022

Seems somewhat related : https://forum.kerbalspaceprogram.com/index.php?/topic/204002-18-112-kspcommunityfixes-bugfixes-and-qol-tweaks/&do=findComment&comment=4198850

I found a pretty severe bug with robotic drift fix. It resets the angle of locked robotic parts after a scene reload.

How to reproduce:

  1. Put a robotic part on a vessel and launch it.
  2. Change the angle of the robotic part and then lock it.
  3. Reload the scene.

The angle of the locked robotic part will reset to its original position, but the part that's attached to the robotic part will not move with it, completely offsetting the hierarchy. Disabling the RoboticsDrift patch removes the issue.

Game version: 1.10.1
Video of the bug: https://youtu.be/hBmhoqfY0K0
KSP.log: https://drive.google.com/file/d/1HR90rLVDlift4dV74Foz9e7lAXjSKuyf
Player.log: https://drive.google.com/file/d/1iGZ6bMPreWflWVdm4FL8Or7CV87HNjgJ

Reproducible on KSP 1.10, not on KSP 1.12
This is caused by differences in the stock robotics code in KSP versions below 1.12
Supporting older versions is frankly not worth it, so corrective action is to limit the patch to KSP 1.12+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants