-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add animations for segmented buttons #109
Conversation
FYI:
I do somewhat like this animation, I might try to find a simpler animation but if not I'll probably merge a CSS-only version of this |
sorry, i'm a fairly js-brained person. would be really nice if you could find a css-only way since the animation jumps atm if you interrupt it and doing it css-only would fix that |
Thoughts on this one? |
i think i prefer my one, but i think yours would make more sense as a default. maybe it could be an option? |
It's not much but it's honest work Note that this was made with transitions instead of keyframe, keyframe would allow for "storing"/"unstoring" the icons in different ways to be closer to your original (eg check is unstored with a 90deg turn while it's stored with a 45deg turn), but I'm not exactly sure how to make it not run on load |
these look great! |
Here's the component's code
|
all looks good to me, other than the a11y ignore (which is necessary due to how you've done the component.) lgtm? |
Oh that was because I was working on the ripple branch. I'll update this branch to it soon, and hopefully will get this merged. |
word. could we get the ripple merged soon? i need it for a project :3 |
i'm fairly sure m3 doesn't animate these icons officially, but it is far too abrupt to ignore right now (at least in my opinion)