Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlined TextField's label has a different background color #82

Closed
wants to merge 3 commits into from

Conversation

DeepBhat
Copy link

First of all, thank you for this great library.

If you use TextFieldOutlined in a parent that does not have scheme-surface as its background color, the label's background color is different and it stands out. It looks weird. This is a quick fix I came up with. Tested it and it works fine for me. Let me know what you think.

@KTibow
Copy link
Owner

KTibow commented Oct 21, 2023

i have a more elegant proposal
use a custom variable with a fallback
you can apply those with a <style> or even per-component with the <Component --a="#fff" /> syntax, and they work without js
hopefully you can update your pr to do that

@KTibow
Copy link
Owner

KTibow commented Oct 21, 2023

oh wait... it already does that!
--m3-util-background
(example of use)

@DeepBhat
Copy link
Author

Oh fair enough haha. I will close this, it's not really needed then.

@DeepBhat DeepBhat closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants