Add code snippet blocks and add highlights to <code> in docs page #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add snippets to use page and fix styling of the snippet
Code cleanup
KTibow
reviewed
Jan 5, 2024
src/routes/docs/+page.svelte
Outdated
Comment on lines
141
to
143
| .number > :global(svg) { | ||
| color: rgb(var(--m3-scheme-on-primary-container)); | ||
| color: inherit; | ||
| } |
There was a problem hiding this comment.
you can drop this declaration entirely
src/routes/docs/Snippet.svelte
Outdated
| <Button on:click={copyToClipboard} type="text" iconType="full"> | ||
| <Icon icon={iconCopy} /> | ||
| </Button> | ||
| <svelte:component this={Snackbar} bind:show={snackbar} /> |
There was a problem hiding this comment.
just use <Snackbar bind:show={snackbar} />
src/routes/docs/Snippet.svelte
Outdated
Comment on lines
37
to
39
| padding-inline-start: 1rem; | ||
| box-sizing: border-box; | ||
| padding-block: 1rem; |
There was a problem hiding this comment.
i don't like how the paddings are all over the place, i would just use a padding: a b c d shorthand here
| import Icon from "$lib/misc/_icon.svelte"; | ||
| import ButtonLink from "$lib/buttons/ButtonLink.svelte"; | ||
| import Snippet from "./Snippet.svelte"; | ||
| import { base } from "$app/paths"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added snippets like mentioned in #81. I've also created highlights around
<code>tag to make it more readable. Feel free to change color tokens if needed.