Clean #20
Merged
Clean #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve indentation - use cat() instead of print() with respect of the "dbg" variable (using new helper function cat_and_run() -> do not depend on the "glue" package - return early within lapply() function
Passing only the package name does not work (any more?)! Check for installed packages out of lapply() and improve the corresponding message
- improve indentation
- improve indentation and spacing
- improve indentation - use one pipe, together with selectElements() from kwb.utils
- return early if ignore_pkgs is NULL - rename "ignore_condition" to "is_ignored"
- use intermediate variable "package_db" - use a magrittr pipe
and reuse this function in get_recursive_pkg_dependencies()
- improve indentation - use "L" to indicate integer
to get rid of R CMD check warnings
mrustl
approved these changes
May 2, 2024
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hsonne)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is