Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \textbackslash and \textasciicircum #1839

Merged
merged 3 commits into from
Jan 27, 2019
Merged

Conversation

edemaine
Copy link
Member

Fix #1838. Conveniently, these characters already seem to be in the fonts (no warnings about metrics).

image

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #1839 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage    94.6%   94.61%   +<.01%     
==========================================
  Files          80       80              
  Lines        4655     4657       +2     
  Branches      810      810              
==========================================
+ Hits         4404     4406       +2     
  Misses        226      226              
  Partials       25       25
Flag Coverage Δ
#screenshotter 88.84% <100%> (ø) ⬆️
#test 86.66% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/symbols.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd37ae...aa31bd9. Read the comment docs.

Copy link
Collaborator

@ronkok ronkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ronkok
Copy link
Collaborator

ronkok commented Jan 26, 2019

Before merging, can you add these functions to the documentation?

@edemaine
Copy link
Member Author

@ronkok Thanks, I forgot! Do you want to review the documentation table change before I merge?

@ronkok
Copy link
Collaborator

ronkok commented Jan 27, 2019

@edemaine I am seeing the oddest thing. When I look at the source text of support_table.md and supported.md, they look fine. But when I look at https://deploy-preview-1839--katex.netlify.com/docs/supported.html, \textasciicircum is there, but \textbackslash is missing. \textbackslash is also missing when I look at the deploy preview of the support table.

Perhaps I am doing something wrong with deploy preview. Any ideas?

@edemaine
Copy link
Member Author

@ronkok I also didn't see the update until remembering to go the "master" version: https://deploy-preview-1839--katex.netlify.com/docs/next/supported.html

@ronkok
Copy link
Collaborator

ronkok commented Jan 27, 2019

Yes, that's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants