This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
forked from FunkinCrew/Funkin
-
Notifications
You must be signed in to change notification settings - Fork 593
Add HTML5 and Linux to CI, improvements to development env #2229
Merged
Kade-github
merged 18 commits into
KadeArchive:master
from
EliteMasterEric:bugfix/github-ci
Sep 11, 2021
Merged
Add HTML5 and Linux to CI, improvements to development env #2229
Kade-github
merged 18 commits into
KadeArchive:master
from
EliteMasterEric:bugfix/github-ci
Sep 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEATURE_ indicates whether a library or class is supported on the target system.
Marked as draft until #2205 is approved and merged. |
thank you |
This was referenced Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependant on #2205.
This pull request provides the following improvements:
#if cpp
or#if desktop
, a single readable define is created inproject.xml
for each use case, such as FEATURE_DISCORD, which defines the circumstances where it is active. Then, that define is used in code (for example, every instance of#if desktop
surrounding the use of a DiscordClient call now uses#if FEATURE_DISCORD
). This makes it easier for developers and maintainers to ensure code is properly included and excluded from certain builds in an intuitive manner.Please get back to me if you have any concerns on this.