Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Add HTML5 and Linux to CI, improvements to development env #2229

Merged
merged 18 commits into from
Sep 11, 2021

Conversation

EliteMasterEric
Copy link

Dependant on #2205.

This pull request provides the following improvements:

  • Github Actions for continuous integration now build properly, resolving Improve Github continuous integration #2207.
  • Added Github Actions for continuous integration of HTML5 and Linux. These now both build properly as well.
  • Added VSCode run configurations for Windows, Linux, and HTML5, with debug and release modes.
  • The code now works on Linux. In order to do this, I had to debug and reposition several compile-time conditional blocks, which was frustrating because I had no way of knowing which defines were for what purpose, thus the below change.
  • Reworked the use of defines to be more human-readable. Instead of using #if cpp or #if desktop, a single readable define is created in project.xml for each use case, such as FEATURE_DISCORD, which defines the circumstances where it is active. Then, that define is used in code (for example, every instance of #if desktop surrounding the use of a DiscordClient call now uses #if FEATURE_DISCORD). This makes it easier for developers and maintainers to ensure code is properly included and excluded from certain builds in an intuitive manner.

Please get back to me if you have any concerns on this.

@EliteMasterEric EliteMasterEric marked this pull request as draft September 11, 2021 18:44
@EliteMasterEric
Copy link
Author

Marked as draft until #2205 is approved and merged.

@Kade-github Kade-github marked this pull request as ready for review September 11, 2021 19:17
@Kade-github Kade-github merged commit 314ceea into KadeArchive:master Sep 11, 2021
@Kade-github
Copy link
Collaborator

thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants