This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
REOPENED: #824 replay fix + modchart fix + stage, gf and noteStyle defaults to their corresponding style if none was found in chart #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay 1.1 still has 1.0 support
as in for modders to copy paste easily
just took an extra \n at the end for some reason
|
reason for reopen: I renamed my |
|
looks great. sorry that pr was kinda rushed since i was porting it over from a mod branch i had on a much older commit of kade engine cuz conflicts are pain! |
|
|
puyoxyz
referenced
this pull request
Jun 14, 2021
'Dad Battle' is now called 'Dad Battle' in game and uses 'dadbattle' as files 'Philly' is now called 'Philly Nice' in game and uses 'philly' as files
|
yeah was about to do that bc I just saw that too in the comments of my previous pr |
Lucky-56
changed the title
puyoxyz
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
testing:
- replay with spaces in song name loads
- replay without spaces in song name loads
- replay details shows the version
- modcharts not tested (i can't, am on linux. someone else test them on songs with spaces in the name before merging!!!!!)
- song with no stage in the json uses the default stage for that week, epic
code looks ok enough
This was referenced Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Adds) Fixes #820
Fixes #862
Fixes #825
Fixes #830
Fixes modcharts (mentioned by this)