Skip to content

Commit

Permalink
fix(pds-link): icons should be imported and set via icon property
Browse files Browse the repository at this point in the history
this is only needed when using internal. the will be similar to how things are done in react.

when using pds-icon as a single webcomponent you can use the name property
  • Loading branch information
ju-Skinner committed Jan 5, 2024
1 parent 90828e0 commit c57a515
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion libs/core/src/components/pds-link/pds-link.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Component, h, Prop } from '@stencil/core';

import { launch } from '@pine-ds/icons/icons';

/**
* @slot - Content is placed between the opening closing tags
*/
Expand Down Expand Up @@ -66,7 +68,7 @@ export class PdsLink {
>
<slot>{this.href}</slot>
{this.external &&
<pds-icon name="launch" size={this.fontSize}></pds-icon>
<pds-icon icon={launch} size={this.fontSize}></pds-icon>
}
</a>
);
Expand Down

0 comments on commit c57a515

Please sign in to comment.