Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select) - new pds-select component #284

Closed
wants to merge 16 commits into from
Closed

Conversation

FuturaExtraBold
Copy link

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any new dependencies or updates that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.
If your type of change is not present, add that option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@FuturaExtraBold FuturaExtraBold self-assigned this Oct 31, 2024
@github-actions github-actions bot added package: core Changes have been made to the Core package package: react Changes have been made to the React package labels Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 31f1499
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/673660afa834e400086c099a
😎 Deploy Preview https://deploy-preview-284--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This reverts commit aedbc86.
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not ready for review, or not in a state to give feedback. Could this PR be put into draft until it's ready for feedback?

@FuturaExtraBold
Copy link
Author

This not ready for review, or not in a state to give feedback. Could this PR be put into draft until it's ready for feedback?

Definitely a work in progress, @QuintonJason. Getting my feet wet.

@FuturaExtraBold FuturaExtraBold marked this pull request as draft October 31, 2024 23:03
@FuturaExtraBold
Copy link
Author

FuturaExtraBold commented Nov 14, 2024

Closing in favor of #310

I didn't have Husky installed, so my commits/branch name will be fixed moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core Changes have been made to the Core package package: react Changes have been made to the React package work in progress (WIP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants