Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): update innerHTML to value #296

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Nov 13, 2024

Description

The textarea's value is not being set properly in the textarea component. This value is currently updated by innerHTML when onTextareaChange is triggered.

Instead of innerHTML, we should use the recommended textarea.value to ensure the content matches what the user types.

Fixes https://kajabi.atlassian.net/browse/DSS-1165

🎩 :hattip to @ju-Skinner for the assist here.

Type of change

Please delete options that are not relevant.
If your type of change is not present, add that option.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Nov 13, 2024
@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 297be43
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/6736625c0c06a000081485f9
😎 Deploy Preview https://deploy-preview-296--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner changed the title fix: update innerHTML to value fix(textarea): update innerHTML to value Nov 13, 2024
@pixelflips pixelflips marked this pull request as ready for review November 14, 2024 21:24
@pixelflips pixelflips requested a review from a team November 14, 2024 21:24
@pixelflips pixelflips requested a review from a team November 14, 2024 22:38
Copy link
Contributor

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocker: did we want to update the documentation alongside this change, as mentioned in the team sync?

@ju-Skinner
Copy link
Collaborator

@monicawheeler I don't believe that we need to. The reason is that we expose the property value and are using value from the underlying textarea so it's a 1:1 match now.

I'm open for further team discussion though.

@monicawheeler
Copy link
Contributor

@ju-Skinner makes sense! Carry on!

@pixelflips pixelflips merged commit 15486d9 into main Nov 15, 2024
16 checks passed
@pixelflips pixelflips deleted the fix/textarea-value branch November 15, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants