Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(box): semantic token updates #319

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ju-Skinner
Copy link
Collaborator

Description

Removes most uses of CSS Custom Props in favor of semantic tokens

Fixes #(issue)

Type of change

  • Visual Changes

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other: Storybook

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added package: core Changes have been made to the Core package package: doc-componenets labels Nov 18, 2024
@ju-Skinner ju-Skinner changed the base branch from main to style/new-tokensets November 18, 2024 16:39
@ju-Skinner ju-Skinner changed the title Style/box semantic token updates style(box): semantic token updates Nov 18, 2024
@ju-Skinner ju-Skinner requested a review from anechol November 18, 2024 16:39
@ju-Skinner ju-Skinner marked this pull request as ready for review November 18, 2024 16:39
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 5d71688
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/673b6da0103f2a00088e2d8d
😎 Deploy Preview https://deploy-preview-319--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner force-pushed the style/box-semantic-token-updates branch from 5d71688 to d3ca726 Compare November 20, 2024 14:37
@ju-Skinner ju-Skinner merged commit 60ec8db into style/new-tokensets Nov 20, 2024
4 checks passed
@ju-Skinner ju-Skinner deleted the style/box-semantic-token-updates branch November 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core Changes have been made to the Core package package: doc-componenets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants