[SAGE-558] Page Heading - update storybook examples and add help props #1389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<h1>
elementBreaking Change:
Notes for implementation
To remove the help or
Popover
content from the<h1>
, a newhelp
prop exists.For the following React pages, you'll need to:
<Popover>
from thePageheading
schildren
help
propScreenshots
Testing in
sage-lib
No visual difference
Visit the Page Heading view and verify that the example match the designs:
In both views verify that the help content exists outside of the
<h1>
element:Testing in
kajabi-products
Pageheading
. Requires implementation to not introduce visual breaking change.Related
Closes SAGE-558