Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAGE-558] Page Heading - update storybook examples and add help props #1389

Merged
merged 3 commits into from
May 10, 2022

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented May 6, 2022

Description

  • update storybook demos to show all variations
  • remove help content to outside of the <h1> element

Breaking Change:

Notes for implementation
To remove the help or Popover content from the <h1>, a new help prop exists.
For the following React pages, you'll need to:

  • move the <Popover> from the Pageheadings children
  • place that content into the help prop
app/javascript/apps/click_report/views/ClickReport/ClickReport.jsx
app/javascript/apps/click_report/views/LinkReport/LinkReport.jsx
app/javascript/apps/dns_settings/DnsSettings.jsx
app/javascript/apps/imports/views/BulkActions/BulkActionsContainer.jsx
app/javascript/apps/imports/views/Confirm/ConfirmContainer.jsx
app/javascript/apps/imports/views/ImportContacts/ImportContacts.jsx
app/javascript/apps/imports/views/MapColumns/MapColumnsContainer.jsx
app/javascript/apps/manage/insights/InsightsContainer.jsx
app/javascript/apps/manage/peoples/contacts/ContactsHeader.jsx
app/javascript/apps/manage/pipelines/PipelineBlueprintsContainer.jsx
app/javascript/apps/manage/pipelines/PipelinesContainer.jsx
app/javascript/apps/products/PostContainer/components/PostHeader/PostHeader.jsx
app/javascript/apps/products/ProductContainer/components/ProductHeader/ProductHeader.jsx
app/javascript/apps/quizzes/admin/components/QuizHeader/QuizHeader.jsx
app/javascript/apps/reporting/components/BaseReport/BaseReportContainer.jsx
app/javascript/apps/reporting/reports/MemberProductProgressReport/MemberProductProgressReport.jsx
app/javascript/stories/mocks/coaching/DashboardPageMock.jsx
app/javascript/stories/mocks/coaching/OAuthPageMock.jsx
app/javascript/stories/mocks/crm/CRMEngagementWidget.jsx
app/javascript/stories/mocks/crm/CRMStatBox.jsx
app/javascript/stories/mocks/domains/GetADomainPage.jsx
app/javascript/stories/mocks/domains/OrderSummary.jsx

Screenshots

Before After
Screen_Shot_2022-05-06_at_9_57_42_AM Screen_Shot_2022-05-06_at_9_57_34_AM

Testing in sage-lib

No visual difference
Visit the Page Heading view and verify that the example match the designs:

In both views verify that the help content exists outside of the <h1> element:

Testing in kajabi-products

  1. (BREAKING) Added new property to Pageheading. Requires implementation to not introduce visual breaking change.
    • Product Index
    • Commerce Index

Related

Closes SAGE-558

@QuintonJason QuintonJason self-assigned this May 6, 2022
@QuintonJason QuintonJason added documentation Improvements or additions to documentation improvement Improve on existing work labels May 6, 2022
@QuintonJason QuintonJason requested review from a team May 6, 2022 14:59
@QuintonJason QuintonJason marked this pull request as ready for review May 6, 2022 14:59
@QuintonJason QuintonJason requested review from a team May 6, 2022 15:04
@QuintonJason QuintonJason force-pushed the SAGE-558_qj-page-heading-docs-and-props branch from 4a15d97 to c1e6a49 Compare May 10, 2022 15:01
@QuintonJason QuintonJason merged commit 8c562a7 into develop May 10, 2022
@QuintonJason QuintonJason deleted the SAGE-558_qj-page-heading-docs-and-props branch May 10, 2022 15:07
@QuintonJason QuintonJason mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improve on existing work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants