Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAGE-567] Hero - add react version #1391

Merged
merged 6 commits into from
May 12, 2022
Merged

[SAGE-567] Hero - add react version #1391

merged 6 commits into from
May 12, 2022

Conversation

QuintonJason
Copy link
Contributor

Description

  • add react version

Screenshots

Screen Shot 2022-05-09 at 12 10 32 PM

Testing in sage-lib

Visit the Hero react view and verify that it is aligned with the rails view:

Testing in kajabi-products

  1. (LOW) Adds new React component. Has no usage in the app

Related

SAGE-567

@QuintonJason QuintonJason self-assigned this May 9, 2022
@QuintonJason QuintonJason added the improvement Improve on existing work label May 9, 2022
@QuintonJason QuintonJason marked this pull request as ready for review May 9, 2022 20:00
@QuintonJason QuintonJason requested review from a team May 9, 2022 20:00
pixelflips
pixelflips approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼 - Nice work!

@pixelflips pixelflips requested a review from a team May 10, 2022 23:41
teenwolfblitzer
teenwolfblitzer requested changes May 11, 2022
View reviewed changes
Copy link
Member

@teenwolfblitzer teenwolfblitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item to check out with the alt attributes

packages/sage-react/lib/themes/legacy/Hero/Hero.jsx Outdated Show resolved Hide resolved
teenwolfblitzer
teenwolfblitzer approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@teenwolfblitzer teenwolfblitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@QuintonJason QuintonJason merged commit 75b08e3 into develop May 12, 2022
@QuintonJason QuintonJason mentioned this pull request May 12, 2022
Merged
@QuintonJason QuintonJason deleted the SAGE-567_qj-hero-react branch December 5, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

@teenwolfblitzer teenwolfblitzer teenwolfblitzer approved these changes

Assignees

@QuintonJason QuintonJason

Labels
improvement Improve on existing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @teenwolfblitzer @pixelflips