Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sage-522] Button - Color Update #1414

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

anechol
Copy link
Contributor

@anechol anechol commented May 18, 2022

Description

Updates primary button color and adds accent variation. Updates secondary button's border color.

Note: Subtle button deprecation will be handled in a future ticket.

Figma

Screenshots

Before After
Screen Shot 2022-05-18 at 2 46 39 PM Screen Shot 2022-05-18 at 2 47 13 PM

Testing in sage-lib

Rails

  • View Button
  • Check that Button colors match Figma specs

React

  • View Button
  • Check that Button colors match Figma specs

Testing in kajabi-products

(HIGH) Sage Next - Updates primary button color and adds accent variation. Updates secondary button's border color.

Related

Sage-522

@anechol anechol self-assigned this May 18, 2022
@anechol anechol force-pushed the SAGE-522_ae-button-color-update branch from 0da8d4e to 6811c92 Compare May 18, 2022 20:21
@anechol anechol added the improvement Improve on existing work label May 18, 2022
@anechol anechol marked this pull request as ready for review May 18, 2022 20:23
@anechol anechol requested review from a team May 18, 2022 20:23
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@anechol anechol force-pushed the SAGE-522_ae-button-color-update branch from 6811c92 to a4d4055 Compare May 19, 2022 20:55
@anechol anechol merged commit 49ca31c into develop May 19, 2022
@anechol anechol deleted the SAGE-522_ae-button-color-update branch May 19, 2022 21:14
This was referenced May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve on existing work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants