Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAGE-529] Update select state color #1419

Merged
merged 2 commits into from
May 25, 2022
Merged

[SAGE-529] Update select state color #1419

merged 2 commits into from
May 25, 2022

Conversation

QuintonJason
Copy link
Contributor

Description

  • Update selected state color to sage-color(charcoal, 400)
    • After full audit, Choice was the only remaining component

Screenshots

Before After
Screen_Shot_2022-05-20_at_2_46_18_PM Screen_Shot_2022-05-20_at_2_48_57_PM

Testing in sage-lib

Verify that the selected state border color is charcoal 400:

  • Rails
  • React -> Click on any of the Choice component to see the desired affect

Note: In React you may see the focus ring on click. That behavior is expected as the active border should appear on load with no interaction

Testing in kajabi-products

  1. (LOW) Update the selected border color for the Choice component.

Related

Closes SAGE-529

@QuintonJason QuintonJason self-assigned this May 20, 2022
@QuintonJason QuintonJason added the improvement Improve on existing work label May 20, 2022
@QuintonJason QuintonJason marked this pull request as ready for review May 20, 2022 20:35
@QuintonJason QuintonJason requested review from a team May 20, 2022 20:35
teenwolfblitzer
teenwolfblitzer approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@teenwolfblitzer teenwolfblitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! As a follow-up, we should label the first Rails example as having an active state, since the distinction may not be obvious at first glance.

@QuintonJason QuintonJason force-pushed the SAGE-529_qj-selected-state-color-update branch from 86b12bb to b8d3841 Compare May 25, 2022 13:12
@QuintonJason QuintonJason mentioned this pull request May 25, 2022
Merged
1 task
@QuintonJason QuintonJason merged commit 9fbde2e into develop May 25, 2022
@QuintonJason QuintonJason deleted the SAGE-529_qj-selected-state-color-update branch May 25, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschanely philschanely philschanely approved these changes

@teenwolfblitzer teenwolfblitzer teenwolfblitzer approved these changes

Assignees

@QuintonJason QuintonJason

Labels
improvement Improve on existing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @teenwolfblitzer @philschanely