Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sage-524] Button - Icon Button Update #1424

Merged
merged 1 commit into from
May 25, 2022

Conversation

anechol
Copy link
Contributor

@anechol anechol commented May 23, 2022

Description

Updates icon only Button variation to new Figma specs:

  • Updates padding to 12px
  • Removes padding on icon. As not all icons are the same dimensions, this should help prevent stretching on mobile layouts and/or small containers.

Note: The icon only variation will be deprecated in this component and made into a separate component. There will be a ticket created for this effort.

Figma

Screenshots

Before After
Screen Shot 2022-05-24 at 9 47 46 AM Screen Shot 2022-05-24 at 9 37 06 AM
Screen Shot 2022-05-24 at 10 18 32 AM Screen Shot 2022-05-24 at 10 21 51 AM

Testing in sage-lib

  • View Button
  • Check that dimensions and padding match Figma specs.

Testing in kajabi-products

(LOW) Updates icon only Button variation to new Figma specs.

Related

Sage-524

@anechol anechol self-assigned this May 23, 2022
@anechol anechol added the improvement Improve on existing work label May 24, 2022
@anechol anechol marked this pull request as ready for review May 24, 2022 15:30
@anechol anechol requested review from a team May 24, 2022 15:30
@QuintonJason QuintonJason self-requested a review May 24, 2022 15:32
@anechol anechol force-pushed the SAGE-524_ae-icon-button-updates branch from 605721b to 5449eae Compare May 25, 2022 15:16
@anechol anechol merged commit fe58981 into develop May 25, 2022
@anechol anechol deleted the SAGE-524_ae-icon-button-updates branch May 25, 2022 15:44
@anechol anechol mentioned this pull request May 31, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve on existing work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants