Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAGE-654] Textarea - resolve issue in safari 14 #1429

Merged
merged 1 commit into from
May 31, 2022
Merged

[SAGE-654] Textarea - resolve issue in safari 14 #1429

merged 1 commit into from
May 31, 2022

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented May 25, 2022 •
edited
Loading

Description

  • add grid-template-rows declaration to resolve layout break in safari 14

Screenshots

Before After
Screen Shot 2022-05-25 at 8 43 36 AM Screen_Shot_2022-05-25_at_8_43_23_AM

Testing in sage-lib

Only visible in Safari 14

  • verify that the layout doesn't break around the textarea component

Testing in kajabi-products

  1. (MEDIUM) Resolve alignment issue with the Textarea component, exclusively in Safari 14.
    • Website -> Pages -> Edit Details

Related

Closes SAGE-654

@QuintonJason QuintonJason marked this pull request as ready for review May 25, 2022 20:18
@QuintonJason QuintonJason requested review from a team May 25, 2022 20:18
@QuintonJason QuintonJason self-assigned this May 25, 2022
@QuintonJason QuintonJason added the improvement Improve on existing work label May 25, 2022
@QuintonJason QuintonJason changed the title [SAGE-654] Text area - resolve issue in safari 14 [SAGE-654] Textarea - resolve issue in safari 14 May 25, 2022
pixelflips
pixelflips approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Phenomenal work! 🔥 🔥

@QuintonJason QuintonJason mentioned this pull request May 31, 2022
Merged
1 task
@QuintonJason QuintonJason force-pushed the SAGE-654_qj-textarea-safari-14-update branch from 0009a44 to 2b1670d Compare May 31, 2022 14:36
@QuintonJason QuintonJason merged commit b55809f into develop May 31, 2022
@QuintonJason QuintonJason deleted the SAGE-654_qj-textarea-safari-14-update branch May 31, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

Assignees

@QuintonJason QuintonJason

Labels
improvement Improve on existing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuintonJason @pixelflips